Skip to content

pyload-ng: init at 0.5.0b3.dev72#233100

Closed
ruby0b wants to merge 2 commits intoNixOS:masterfrom
ruby0b:pyload
Closed

pyload-ng: init at 0.5.0b3.dev72#233100
ruby0b wants to merge 2 commits intoNixOS:masterfrom
ruby0b:pyload

Conversation

@ruby0b
Copy link
Contributor

@ruby0b ruby0b commented May 20, 2023

Description of changes

This packages the newer pyload-ng version of pyload, a download manager with support for 1-click-hosting sites.

The old pyload got dropped from nixpkgs in 2021 due to being unmaintained: c0914a7

Potential future work: writing a NixOS service for autostarting

Things done
  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label May 20, 2023
@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by a maintainer of all the package it changes. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels May 20, 2023
@ruby0b
Copy link
Contributor Author

ruby0b commented May 21, 2023

should the pyload throw alias be removed then (or mention the pyload-ng package)?

@SuperSandro2000
Copy link
Member

we could do that

@ruby0b ruby0b requested a review from SuperSandro2000 May 24, 2023 15:56
@ofborg ofborg bot added the ofborg-internal-error Ofborg encountered an error label May 24, 2023
@SuperSandro2000
Copy link
Member

@ofborg eval

Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two minor things, otherwise LGTM

@ruby0b ruby0b closed this Jun 3, 2023
@github-actions github-actions bot removed the 6.topic: python Python is a high-level, general-purpose programming language. label Jun 3, 2023
@ruby0b ruby0b changed the title pyload-ng: init at 0.5.0b3.dev69 pyload-ng: init at 0.5.0b3.dev71 Jun 3, 2023
@ruby0b ruby0b reopened this Jun 3, 2023
@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jun 3, 2023
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ofborg eval

@ruby0b ruby0b changed the title pyload-ng: init at 0.5.0b3.dev71 pyload-ng: init at 0.5.0b3.dev72 Jun 19, 2023
@ruby0b
Copy link
Contributor Author

ruby0b commented Jun 19, 2023

should be ready now :)

@cole-h cole-h removed the ofborg-internal-error Ofborg encountered an error label Jun 21, 2023
@ruby0b ruby0b requested a review from SuperSandro2000 June 29, 2023 14:39
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rebase otherwise LGTM

@ruby0b
Copy link
Contributor Author

ruby0b commented Jul 8, 2023

Oh, I had to force push since the histories had diverged, makes sense in retrospect. Sorry for pinging like 50 people :')

@ruby0b ruby0b requested a review from SuperSandro2000 July 8, 2023 11:21
@Ma27
Copy link
Member

Ma27 commented Jul 8, 2023

Please file a new PR: we cannot unsubcribe everyone, so all the activity in here will ping a lot of people.

@Ma27 Ma27 closed this Jul 8, 2023
@NixOS NixOS locked and limited conversation to collaborators Jul 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

6.topic: python Python is a high-level, general-purpose programming language. 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 11.by: package-maintainer This PR was created by a maintainer of all the package it changes.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants